Cron Job Bugs & Errors

[cinique]

As requested by Sandeep in another thread..
First thread/post in a series, starting with some obvious cron ones.
(The first two don't appear when run on different VPSes - in fact there's quite a variation!)

Code Select Expand

/usr/local/cwp/php71/bin/php-cgi -d max_execution_time=10000000 -q /usr/local/cwpsrv/htdocs/resources/admin/include/cron_newbackup.php
Output

PHP Warning:  count(): Parameter must be an array or an object that implements Countable in /usr/local/cwpsrv/htdocs/resources/admin/addons/class_backupmanager.php on line 0

Code Select Expand

/usr/local/cwp/php71/bin/php -d max_execution_time=18000 -q /usr/local/cwpsrv/htdocs/resources/admin/include/alertandautorenewssl.php
Output

[]

Code Select Expand

/usr/local/cwp/php71/bin/php -d max_execution_time=18000 -q /usr/local/cwpsrv/htdocs/resources/admin/include/cron_autossl_all_domains.php
Output

CREATION FAILEDS: 0
CREATEDS: 0
RENEWAL FAILEDS: 0
RENEWEDS: 0

As pointed out before, should be failures, created and renewals <-- easy fix

Code Select Expand

/etc/cron.daily/cwp
Output

Database Backup: mysql --> /backup/mysql/weekly//mysql.sql

All backup paths have a duplicated trailing / <-- easy fix

[cinique]

RENEWEDS = short form of "Renew Wedding Vows"?   

[mrmorales]

RENEWEDS = short form of "Renew Wedding Vows"?   

Ohh may be guy DEV this need renew his weed... sorry his weddding vows

[Sandeep]

thanks it will be fixed in next few updates.

[cinique]

Not so much a bug or error but a functional/operational issue, this one..

/etc/cron.daily/cwp

###########################
Firewall Flush Daily Blocks
###########################

Why clear the blocks each day? CSF does automatic blocks rotation, which is a much more effective means handling blocked IPs.

Consider a hacking attempt that is probing ports at 23:58 (just before midnight), whereby their IP gets correctly blocked. Then your daily cron runs and allows them back on, within minutes. Not good.

Is there a specific reason to flush the blocked IPs?

[cinique]

Doesn't look as if much is happening to address the previous errors. 

Another one to add to the list:

PHP Notice:  Undefined variable: [obfuscated] in /usr/local/cwpsrv/htdocs/resources/admin/include/security_advisor/security_advisor.php on line 0

[NFT]

thanks it will be fixed in next few updates.

Well still not fixed this "alertandautorenewssl" empty "[]" mail also reported here without any response
http://forum.centos-webpanel.com/index.php?topic=9205.msg32278#msg32278