Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Pages: [1]
1
CentOS-WebPanel Bugs / Re: PHP Version Switcher has no error checking at all.
« on: November 15, 2021, 12:14:42 AM »
Sure, but seeing an error and then more entries in the log suggests that the error wasn't fatal at all, and that the script proceeded as intended. Not failing after a critical error is simply bad, there's no other way to say it.
2
CentOS-WebPanel Bugs / PHP Version Switcher has no error checking at all.
« on: November 14, 2021, 03:44:28 PM »
The php-rebuild.sh script has no error checking for failures in "configure" or "make" steps. If `configure` fails, for some reason (like the infamous oniguruma/oniguruma5 dependency conflict), the script continues and does nothing to inform the user of the error, and proceeds to handle `php.ini` edits and everything. There should MANDATORILY be an error trap, even as simple as `|| die "Configure failed with error $?"` sprinkled around the script.
Pages: [1]
