Author Topic: PHP Version Switcher has no error checking at all.  (Read 2121 times)

0 Members and 1 Guest are viewing this topic.

Offline
*
PHP Version Switcher has no error checking at all.
« on: November 14, 2021, 03:44:28 PM »
The php-rebuild.sh script has no error checking for failures in "configure" or "make" steps. If `configure` fails, for some reason (like the infamous oniguruma/oniguruma5 dependency conflict), the script continues and does nothing to inform the user of the error, and proceeds to handle `php.ini` edits and everything. There should MANDATORILY be an error trap, even as simple as `|| die "Configure failed with error $?"` sprinkled around the script.

Offline
*****
Re: PHP Version Switcher has no error checking at all.
« Reply #1 on: November 14, 2021, 03:52:37 PM »
you've php build log where you can search and check the errors.

Offline
*
Re: PHP Version Switcher has no error checking at all.
« Reply #2 on: November 15, 2021, 12:14:42 AM »
Sure, but seeing an error and then more entries in the log suggests that the error wasn't fatal at all, and that the script proceeded as intended. Not failing after a critical error is simply bad, there's no other way to say it.
« Last Edit: November 15, 2021, 12:16:17 AM by sinuspi »

Offline
*****
Re: PHP Version Switcher has no error checking at all.
« Reply #3 on: November 15, 2021, 10:39:37 AM »
for now your only solution is to view the log, in future we can add more checks but don't know when it will be implemented.